[V6] geth --dev test fixture setup
#3209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing: - Quicker timeout for unmined wait-for-txn-receipt tests - Update default fees test for geth --dev mode - Get rid of all miner start() and stop() references - Run integration tests with --dev flag - Test refactoring for ``geth --dev`` test fixture setup - Remove PoW related endpoint tests; TODO: remove / deprecate endpoints - Support latest geth versions - Update geth version in circleCI config + peripherally related changes - Turn on PoS block identifier tests - get geth --dev test suite working
- Flaky for replace transaction - Fix typing - Loosen assertions on gas - Nonce value fix - Loosen asserts for default maxFeePerGas and maxPriorityFeePerGas tests
- Add @flaky to tests that expect mining at certain times - This isn't ideal. Perhaps we can increase the ``dev.period`` (mining interval) to make these tests a bit more reliable and hopefully the other tests are unaffected. - Update benchmark to run with ``geth --dev`` setup - Put back old state of get_logs_without_logs for eth_tester
- Try with --dev.period=5 - Remove assert from test_eth_new_block_filter - Remove sleep from test_web3_client_version - Try without flaky - Fixes test_eth_send_transaction_with_nonce without the need for retries. - Retries were causing transactions to be sent with the same nonce, which in turn requires more gas to go through. Running the test once fixes this issue. - Obtain the transaction count providing the 'pending' argument. - Fix test_eth_send_transaction_no_max_fee
reedsa
changed the title
geth --dev fixture setupgeth --dev test fixture setup
reedsa
force-pushed
the
v6-geth-1.13.9-upgrade
branch
from
fa105cc to
fff7fe1
Compare
reedsa
force-pushed
the
v6-geth-1.13.9-upgrade
branch
from
fff7fe1 to
4caf083
Compare
fselmo
approved these changes
Jan 29, 2024
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #3188
How was it fixed?
Todo:
Cute Animal Picture