Skip to content

Remove dep upper pins #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 14, 2022

What was wrong?

We're moving to allow a wider set of dependencies. This gives the power to the user to specify the versions they need without getting in the way. See this article with the referenced links for justification.

How was it fixed?

Removed all upper pins on dependencies that won't break.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the remove-dep-upper-pins branch from 9695b5a to d4cd5f4 Compare October 26, 2022 21:17
@kclowes kclowes marked this pull request as ready for review October 27, 2022 17:49
@kclowes kclowes requested review from fselmo and pacrob October 27, 2022 17:49
@kclowes kclowes mentioned this pull request Oct 27, 2022
22 tasks
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes force-pushed the remove-dep-upper-pins branch from 0f9d1ea to 51b0bf6 Compare October 27, 2022 20:51
@kclowes kclowes merged commit deaf5bd into ethereum:master Oct 27, 2022
@kclowes kclowes deleted the remove-dep-upper-pins branch October 27, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants