Deprecate Geth Admin StartRPC and StopRPC #2507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
changed the title
pacrob
force-pushed
the
deprecate-geth-admin-start-stop-rpc
branch
8 times, most recently
from
9ffe02b to
e92c17a
Compare
fselmo
reviewed
Jun 9, 2022
pacrob
force-pushed
the
deprecate-geth-admin-start-stop-rpc
branch
from
e92c17a to
dde1336
Compare
fselmo
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
StartRPC and StopRPC are being deprecated for StartHTTP and StopHTTP, per comments in geth:
https://github.com/ethereum/go-ethereum/blob/778ff947944f388e2a0307764a182a5521886081/node/api.go#L221
How was it fixed?
Deprecated them in Geth Admin
Todo:
Cute Animal Picture