Pin eth-rlp<0.3 #2502
Merged
Pin eth-rlp<0.3 #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
changed the title
fselmo
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
LGTM 👍. Based on our discussion earlier, I think this helps avoid a round of breaking changes. If we could track this for the next round of major updates to eventually pin it to eth-account that would be nice. We could add a comment on this line or just make a note somewhere else maybe?
|
Comment added! I'll also add an issue in eth-account to tighten up the eth-rlp dependency requirement over there and we can pull it into the next breaking release on eth-account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth-accounthas a typo (I believe) here, which causes dependency resolution errors for us on older versions of pip, before they changed their dependency resolution.I could be convinced that this change belongs in
eth-accountif someone feels strongly, but I think it belongs here because it's breaking here.Closes #2424
How was it fixed?
Pinned
eth-rlpto<0.3to support older versions of pip.Todo:
Cute Animal Picture