Skip to content

Fix test for the web3_api #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix test for the web3_api #2368

merged 1 commit into from
Feb 28, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Feb 28, 2022

What was wrong?

When I bumped web3 to version 6, our web3_api test started failing on master.

How was it fixed?

Updated the test. It would be nice to figure out a way to catch this before the new version is released, but deprioritizing for now.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes requested review from wolovim and pacrob February 28, 2022 18:32
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 32f5379 into ethereum:master Feb 28, 2022
@kclowes kclowes deleted the fix-w3-api-test branch February 28, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants