Rethink eth_chainId calls
#2266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
rethink-eth_chainId-calls
branch
from
fd3fa9d to
2ee00e6
Compare
The `chain_id` value should not change much, if at all. Save this value internally, as `internal_chain_id`, so we are not making extra calls to get the `chain_id` when it is not necessary. This was preferred over caching the `w3.eth.chain_id` call so that when we explicitly use `w3.eth.chain_id`, we actually make the call in ernest and return the response.
fselmo
force-pushed
the
rethink-eth_chainId-calls
branch
from
2ee00e6 to
020cc42
Compare
|
closed since caching seems like the best idea here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth_chainIdto validate thechainIdparam in a transaction, or to add the default value to each transaction making use of default values (i.e.contract.buildTransaction()).Related to Issue #2207
How was it fixed?
One possible solution is setting an internal chain id value on provider instantiation
Another solution would be to cache the call to
eth_chainIdw3.eth.chain_id, on its own, would return the cached value and would not be an earnest call.