Skip to content

Conversation

@fselmo
Copy link
Collaborator

@fselmo fselmo commented May 7, 2025

What was wrong?

  • Small addition to clean old test fixtures when generating a new test fixture

Todo:

  • Clean up commit history

Cute Animal Picture

Screenshot 2025-05-07 at 13 30 26

@fselmo fselmo force-pushed the remove-old-fixtures-when-generating-fixture branch from d39792a to 7b024d9 Compare May 7, 2025 19:35
@fselmo fselmo requested review from kclowes, pacrob and reedsa May 7, 2025 19:35
@fselmo fselmo self-assigned this May 7, 2025
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the test fails are flakes, :shipit:

@fselmo
Copy link
Collaborator Author

fselmo commented May 7, 2025

As long as the test fails are flakes, :shipit:

Looks like flakes... I wonder if related to test fixture update... I'll take a look there

@fselmo fselmo merged commit f6f4fd3 into ethereum:main May 7, 2025
85 checks passed
@fselmo fselmo deleted the remove-old-fixtures-when-generating-fixture branch May 7, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants