-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Upgrade template #3610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade template #3610
Conversation
* Store artifacts in docs CI * Force `pytest` import above all else
bump-my-version
remove unneeded upstream git check
- We should create a breaking changes branch to be merged only when we are ready to start the next major version release cycle for all our maintained libraries.
making -> make
newsfragment should not be italics
ed972e9 to
db12704
Compare
kclowes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I left some minor fix ideas & double checks.
db12704 to
2eef74b
Compare
| .. code:: sh | ||
| $ pip install "web3[dev]" | ||
| $ python -m pip install py-solc-x black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏼
fselmo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Merge updates from the template, replacing
bumpversionwithbump-my-version. py313 support was previously added.docs/contributing.rstgot some extra cleanup and validation.Todo:
Cute Animal Picture