Skip to content

Conversation

@fselmo
Copy link
Collaborator

@fselmo fselmo commented Feb 4, 2025

What was wrong?

  • Remove note about ENSIP-15 breaking changes from v6
  • Remove old, un-tested uncles tests as they are no longer a thing after switch to PoS.
  • Change TODO note on breaking changes from v7 -> v8

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

courtesy of gpt o3-mini-high 🤔

       .-=========-.
       |  IRISH    |
       |  DOODLE   |
       '-----------'
            ||
         .-'''''-.
       .'  .-. .-.  '.
      /   ( o ) ( o )  \
     |     '-'   '-'    |
     |  \             / |
      \  '.         .'  /
       '.  `'-----'`  .'
         '-._______.-'
           |     |
         __|     |__
        /  |     |  \
       /   |     |   \
      /____|_____|____\
         (_________)

@fselmo fselmo marked this pull request as ready for review February 4, 2025 22:18
@fselmo fselmo changed the title Rm ensip15 note Remove /update old notes & remove some old skipped tests Feb 4, 2025
@fselmo fselmo changed the title Remove /update old notes & remove some old skipped tests Remove / update old notes & remove some old skipped tests Feb 4, 2025
@fselmo
Copy link
Collaborator Author

fselmo commented Feb 4, 2025

Chore PR to remove some old things. Follow-up q, should we deprecate eth_getUncle* endpoints / methods to be removed in v8? Could add that in here as well while eyes are there.

@fselmo fselmo requested review from kclowes, pacrob and reedsa February 4, 2025 22:37
@pacrob
Copy link
Contributor

pacrob commented Feb 5, 2025

Chore PR to remove some old things. Follow-up q, should we deprecate eth_getUncle* endpoints / methods to be removed in v8? Could add that in here as well while eyes are there.

makes sense to me

@pacrob pacrob removed their request for review March 25, 2025 12:02
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌟

@fselmo fselmo merged commit 5dda5d6 into ethereum:main Apr 28, 2025
85 checks passed
@fselmo fselmo deleted the rm-ensip15-note branch April 28, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants