Skip to content

update EthereumTesterProvider docs #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2024
Merged

update EthereumTesterProvider docs #3500

merged 1 commit into from
Sep 28, 2024

Conversation

@pacrob
Copy link
Contributor

@pacrob pacrob commented Sep 26, 2024 •
edited
Loading

What was wrong?

EthereumTesterProvder docs had arg name eth_tester, should be ethereum_tester.

How was it fixed?

  • corrected arg name
  • added missing api_endpoints arg + explanation
  • added existence of `AsyncEthereumTesterProvider
  • cleaned up line length for readability
  • added double-quotes around extras install for zsh compatibility

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@pacrob pacrob force-pushed the tester-provider-doc-fix branch from 45f3333 to 7a0f334 Compare September 26, 2024 21:02
@pacrob pacrob marked this pull request as ready for review September 26, 2024 21:13
@pacrob pacrob requested review from fselmo, kclowes and reedsa September 26, 2024 21:13
kclowes
kclowes reviewed Sep 26, 2024
View reviewed changes
@pacrob pacrob force-pushed the tester-provider-doc-fix branch from 7a0f334 to a8349aa Compare September 27, 2024 21:20
fselmo
fselmo approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pacrob pacrob merged commit 6f923ee into ethereum:main Sep 28, 2024
1 check passed
@pacrob pacrob deleted the tester-provider-doc-fix branch September 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kclowes kclowes kclowes left review comments

@fselmo fselmo fselmo approved these changes

@reedsa reedsa Awaiting requested review from reedsa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pacrob @fselmo @kclowes