Fix buffer issues with async IPC; add tests #3492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
fix-issues-with-ipc-socket-read
branch
4 times, most recently
from
800b091 to
751dd72
Compare
- Move to a readline() approach on the stream reader for IPC. The older implementation for the original IPC would read in chunks but this isn't ideal and, it turns out, opting for readline while allowing control of the buffer limit lends itself quite nicely to plucking well-formed responses from the socket.
fselmo
force-pushed
the
fix-issues-with-ipc-socket-read
branch
from
751dd72 to
91cb2d5
Compare
Member
|
I wonder if chunks can arrive in arbitrary order. Also this thread discusses possible solutions. |
fselmo
force-pushed
the
fix-issues-with-ipc-socket-read
branch
from
dfc96b0 to
4ee81d3
Compare
- Document ``read_buffer_limit`` on the ``AsyncIPCProvider`` class. - Add ``ReadBufferLimitReached`` exception to be raised when the read buffer limit is reached, prompting the user to increase the limit. - Add a base ``PersistentConnectionError`` exception class for persistent connection errors to inherit from.
fselmo
force-pushed
the
fix-issues-with-ipc-socket-read
branch
from
4ee81d3 to
8504dd9
Compare
Collaborator
Author
|
@raxhvl thanks for reporting. I believe this will be a more straightforward approach that can give control to the user to configure the read buffer limit if needs to be even larger than the default of 20MB. This should resolve your issues and I added a test to test this limit. |
kclowes
approved these changes
Sep 20, 2024
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
I left a couple questions to take or leave, but generally looks good to me! Much cleaner! 🧹
- Also inherit from ``Web3ValueError`` for ``ReadBufferLimitReached``. - Properly assert the response for configured read limit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #3485
How was it fixed?
readline()approach on the stream reader for IPC. The older implementation for the original IPC would read in chunks but this isn't ideal and, it turns out, opting for readline while allowing control of the buffer limit lends itself quite nicely to plucking well-formed responses from the socket.Todo:
Cute Animal Picture