-
Notifications
You must be signed in to change notification settings - Fork 1.8k
docs: fixed typos in pip install "web3[test]" #3480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for this PR! I think what we actually want to do is add the Edit: Oops, should include |
|
Hey @kclowes, sure! I can handle that myself. I'll change the PR later tomorrow when I'm done with some work. |
|
Sounds great! Thank you! |
|
Hey @kclowes, just pushed a new commit replacing my previous commit (clean commit history 😉). Please check it out when you can and let me know if I forgot anything, I'm available to adjust any point. Edit: I forgot to mention, I added both |
|
Looking good! We'll want to add |
|
Ok, just a min. |
|
Done! Just replaced the commit again to keep the history clean. |
Taking a look in the checks that failed here, I think that maybe we shouldn't remove the dependencies from test? 🤔 Just guessing. |
kclowes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Those were just flaky tests. I'll add a newsfragment and merge. Thank you!
What was wrong?
I tried to install the project with "tester", following the current documentation in a project and the dependencies for testing (eth_tester) were not installed.
When checking the current setup.py I found that the correct command to do would be
pip install web3[test]and notpip installl web3[tester].How was it fixed?
I changed the documentation in every reference I could find from
pip install web3[tester]topip install web3[test].Todo:
Cute Animal Picture