Skip to content

Conversation

@LuizDMM
Copy link
Contributor

@LuizDMM LuizDMM commented Sep 9, 2024

What was wrong?

I tried to install the project with "tester", following the current documentation in a project and the dependencies for testing (eth_tester) were not installed.

When checking the current setup.py I found that the correct command to do would be pip install web3[test] and not pip installl web3[tester].

How was it fixed?

I changed the documentation in every reference I could find from pip install web3[tester] to pip install web3[test].

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

hedgehog-1215140_1920

@kclowes
Copy link
Collaborator

kclowes commented Sep 11, 2024

Thank you for this PR! I think what we actually want to do is add the tester optional dependency back. It should include py-evm and eth-tester. It looks like it got inadvertently taken out. If you're up for changing this PR, that would be great, otherwise I'll get to it over the next few days.

Edit: Oops, should include py-geth and eth-tester. py-evm will be installed via eth-tester[py-evm]

@LuizDMM
Copy link
Contributor Author

LuizDMM commented Sep 11, 2024

Hey @kclowes, sure! I can handle that myself. I'll change the PR later tomorrow when I'm done with some work.

@kclowes
Copy link
Collaborator

kclowes commented Sep 11, 2024

Sounds great! Thank you!

@LuizDMM
Copy link
Contributor Author

LuizDMM commented Sep 12, 2024

Hey @kclowes, just pushed a new commit replacing my previous commit (clean commit history 😉). Please check it out when you can and let me know if I forgot anything, I'm available to adjust any point.

Edit: I forgot to mention, I added both py-geth and eth-tester in the current versions used in the test optional dependencies.

@kclowes
Copy link
Collaborator

kclowes commented Sep 13, 2024

Looking good! We'll want to add extras_require["tester"] to the dev dependencies on line 47, and we can remove eth-tester and py-geth from the test requirements. Thanks!

@LuizDMM
Copy link
Contributor Author

LuizDMM commented Sep 13, 2024

Ok, just a min.

@LuizDMM
Copy link
Contributor Author

LuizDMM commented Sep 13, 2024

Done! Just replaced the commit again to keep the history clean.

@LuizDMM
Copy link
Contributor Author

LuizDMM commented Sep 13, 2024

Looking good! We'll want to add extras_require["tester"] to the dev dependencies on line 47, and we can remove eth-tester and py-geth from the test requirements. Thanks!

Taking a look in the checks that failed here, I think that maybe we shouldn't remove the dependencies from test? 🤔 Just guessing.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Those were just flaky tests. I'll add a newsfragment and merge. Thank you!

@kclowes kclowes merged commit 31afba6 into ethereum:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants