Correct the .encode_abi code example snippet in the docs (web3.contract.rst) #3473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, fn_name was a named argument, used like:
```
contract.encode_abi(fn_name="register", ...)
```
But now, fn_name is the unnamed first argument, used like:
```
contract.encode_abi("register", ...)
```
(I believe, at least - I note that line 326, which defines the class method, uses it this way:
```
.. py:classmethod:: Contract.encode_abi(fn_name, args=None, kwargs=None, data=None)
```
And in my local project `encode_abi("getNames", ...)` worked where `encode_abi(fn_name="getNames", ...)` did not.
Contributor
|
Thanks, @flanagansteve! I've updated related places, otherwise should be gtg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
fn_namewas a named argument in the example snippet, used like:But now,
fn_nameis the unnamed first argument, used like:(I believe, at least - I note that line 326, which defines the class method, uses it this way:
And in my local project
encode_abi("getNames", ...)worked whereencode_abi(fn_name="getNames", ...)did not, which makes me thinkencode_abi("register", ...)is indeed the correct one.Cute Animal Picture