get_request_headers combomethod

[kclowes]

What was wrong?

@antazoey requested that get_request_headers be exposed as a class method.

Closes #3466

How was it fixed?

Added a check to see where to get the class name from, and a combomethod decorator, so it can be called either way.

Todo:

• Clean up commit history
• Add or update documentation related to these changes
• Add entry to the release notes

Cute Animal Picture

[fselmo]

lgtm 👍🏼

[pacrob]

🐑

[souliane]

Hi, I am wondering why you chose to use @combomethod instead of the stdlib @classmethod? It would also work with self.get_request_headers():

In [1]: class A:
   ...:     @classmethod
   ...:     def test(cls):
   ...:         print(cls)
   ...: 

In [2]: A.test()
<class '__main__.A'>

In [3]: A().test()
<class '__main__.A'>

Did I miss something?

[kclowes]

Mostly codebase consistency, and to make it explicit that calling it either way is fine and by design.