Allow ContractFunctions to be called via a combomethod style #3444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
reviewed
Jul 31, 2024
kclowes
changed the title
kclowes
force-pushed
the
validate-contract-fn-args-kwargs
branch
from
9b7f6cb to
013db7b
Compare
kclowes
force-pushed
the
validate-contract-fn-args-kwargs
branch
from
b78607f to
aaa9f50
Compare
kclowes
force-pushed
the
validate-contract-fn-args-kwargs
branch
from
aaa9f50 to
fc0cd9d
Compare
reedsa
approved these changes
Aug 23, 2024
Contributor
reedsa
left a comment
reedsa
left a comment
There was a problem hiding this comment.
Really nice to have this, fits nicely with the events API. lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We've agreed that it would be nice if ContractFunctions can be called both with and without parentheses if the function doesn't take arguments or keyword arguments. Both examples are okay below:
myContract.functions.myFnName().call()myContract.functions.myFnName.call()Related to Issue #2545
Closes #2541
How was it fixed?
Added a tuple or a dict as fallback if either
**argsor**kwargsareNoneTodo:
Cute Animal Picture