Port similar changes from #3424 to main / v7: #3432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
port-3424-to-main
branch
2 times, most recently
from
ef8a38e to
3c6e9dc
Compare
- Similar changes as ethereum#3424 that were implemented for ``v6``. - Raise ``PersistentConnectionClosedOK`` if a ``ConnectionClosedOK`` is raised by the server for a websocket provider. Handle this appropriately in a pattern than can be applicable to other persistent connections by creating a new internal exception that is then handled, rather than handling the specific websocket exception.
fselmo
force-pushed
the
port-3424-to-main
branch
from
3c6e9dc to
e798e76
Compare
fselmo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Implement similar logic made in #3424 for
v7/mainbranch, gracefully handling the case ofConnectionClosedOKfor websocket connections.How was it fixed?
PersistentConnectionClosedOKexception, triggering an end to the message listener task and breaking out of theprocess_subscriptions()iterator.Since we have very different socket logic between
AsyncIPCProviderandWebSocketProvider, handle the specific websocket case inside the_provider_specific_message_listener()method. For WebSocket case, if aConnectionClosedOKis raised, silence it and re-raise aPersistentConnectionClosedOK.I don't currently see an equivalent case for
AsyncIPCProviderso this pattern isn't utilized for that specific provider.Todo:
Cute Animal Picture