-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix eth create access list #3327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed1047d to
a34ca84
Compare
a34ca84 to
d9c4d69
Compare
kclowes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
| assert int(response["gasUsed"]) >= 0 | ||
|
|
||
| # assert the result can be used directly in a transaction dict | ||
| txn["accessList"] = response["accessList"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if this works out of the box, then you can probably revert some of your fixes in the documentation.
Specifically, where the documentation describes this is part in the output of that function:
'accessList': [
AttributeDict({
'address': '0xde0B295669a9FD93d5F28D9Ec85E40f4cb697BAe',
'storageKeys': [
HexBytes('0x0000000000000000000000000000000000000000000000000000000000000003'),
HexBytes('0x0000000000000000000000000000000000000000000000000000000000000007'),
]
}),
AttributeDict({
'address': '0xBB9bc244D798123fDe783fCc1C72d3Bb8C189413',
'storageKeys': []
}),
],
If the AttributeDict and HexBytes are really part of this output, then I'd expect txn to become illegal (cannot be unmarshalled by Go, or something similar to that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be handling that in our formatters before it gets passed to the client
What was wrong?
Closes #3321
How was it fixed?
HexBytesorbytesTodo:
Cute Animal Picture