feature: add RPC eth_getBlockReceipts #3247
Conversation
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Thank you for this PR! Let me know if any of my comments don't make sense or need clarification.
|
|
||
| def test_eth_fee_history(self, w3: "Web3") -> None: | ||
| super().test_eth_fee_history(w3) | ||
| def test_eth_getBlockReceipts_hash( |
There was a problem hiding this comment.
Since we don't have eth_getBlockReceipts implemented in eth-tester, we'll need to add these tests to the not_implemented section that's closer to the beginning of this file.
There was a problem hiding this comment.
Excuse me, may I ask if this is the change? It seems that even after the change here, it has not taken effect
There was a problem hiding this comment.
Thanks for the ping. Now that you are listing the tests as not_implemented above, you can delete them here and the tests should pass.
|
I don't think this is failing due to anything you added, @jsvisa. I'll see if I can straighten it out. Thanks! |
kclowes
force-pushed
the
eth_getBlockReceipts
branch
from
b65a436 to
0d83c74
Compare
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
kclowes
force-pushed
the
eth_getBlockReceipts
branch
from
1576a28 to
8b56d40
Compare
2 participants
What was wrong?
Related to Issue #2004
How was it fixed?
eth_getBlockReceiptswas introduced in the standard RPC ethereum/execution-apis#438, we can simply implement itTodo:
Cute Animal Picture