Contract Events Sorted by ContractEvent.logIndex and ContractEvent.blockNumber
#3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
force-pushed
the
961-sort-contract-events
branch
from
61de8ba to
f94b8ec
Compare
reedsa
pushed a commit
to reedsa/web3.py
that referenced
this pull request
Feb 9, 2024
reedsa
force-pushed
the
961-sort-contract-events
branch
from
f94b8ec to
0212931
Compare
kclowes
approved these changes
Feb 9, 2024
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
LGTM! Do we need to update any docs?
reedsa
pushed a commit
to reedsa/web3.py
that referenced
this pull request
Feb 9, 2024
reedsa
force-pushed
the
961-sort-contract-events
branch
from
0212931 to
7a4cef1
Compare
reedsa
force-pushed
the
961-sort-contract-events
branch
from
7a4cef1 to
531fb30
Compare
Contributor
Author
|
Committed a change to also sort the events by |
reedsa
changed the title
ContractEvent.logIndex and ContractEvent.blockNumber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #961
How was it fixed?
Pass log entries list through
sortedto return a list sorted by all event'sblockNumberandlogIndexesTodo:
Cute Animal Picture