Skip to content

Conversation

@reedsa
Copy link
Contributor

@reedsa reedsa commented Dec 12, 2023

What was wrong?

Closes #3163

How was it fixed?

Implement RPC method for async createAccessList

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa requested review from fselmo, kclowes and pacrob December 13, 2023 19:52
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I realized that the async flaky integration tests aren't running either, so I just put up a quick PR (#3170).

@kclowes kclowes mentioned this pull request Dec 15, 2023
1 task
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiniest of nits, lgtm, take or leave 👍🏼

@reedsa reedsa merged commit 09048b2 into ethereum:main Dec 18, 2023
@reedsa reedsa deleted the async-create-access-list branch March 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async createAccessList

4 participants