Add yParity to TxData type class
#3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ``yParity`` was a recent addition to geth json transaction data. We added formatters for it but we missed it in the ``TxData`` class.
fselmo
force-pushed
the
add-yparity-to-txdata
branch
from
8dd937d to
1bf39f5
Compare
reedsa
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
yParitywas a recent addition to geth json transaction data. We added formatters for it but we missed it in theTxDataclass.How was it fixed?
TxDatato haveyParityfield asinttypeTodo:
Cute Animal Picture