Fix contract function name collision #3147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Caller incase it has been replaced.
reedsa
force-pushed
the
fix-contract-function-name-collision
branch
2 times, most recently
from
cc32b59 to
8fbb7f6
Compare
reedsa
force-pushed
the
fix-contract-function-name-collision
branch
from
6a1080c to
d1786cd
Compare
reedsa
force-pushed
the
fix-contract-function-name-collision
branch
from
70e9cc1 to
f812c43
Compare
reedsa
force-pushed
the
fix-contract-function-name-collision
branch
from
f812c43 to
0ee00db
Compare
fselmo
reviewed
Nov 11, 2023
Collaborator
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
I left some nits, let me know what you think on those. We should add the async version of the main ABI test here too though before merging.
reedsa
force-pushed
the
fix-contract-function-name-collision
branch
from
4e6c9d4 to
690ea18
Compare
reedsa
force-pushed
the
fix-contract-function-name-collision
branch
from
690ea18 to
9318da4
Compare
fselmo
reviewed
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #2955
Could not push to the fork, this is continued from #2956.
How was it fixed?
Addressed name collision for
w3variable name when initializing a contract by using the argument provided in the init function itself.Also fixed async, which suffered from the same issue.
Todo:
Cute Animal Picture