Add unindexed event arg filtering support for get_logs #3078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
update-get-logs-params
branch
5 times, most recently
from
6fdb44e to
02ff291
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Aug 16, 2023
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Aug 16, 2023
fselmo
force-pushed
the
update-get-logs-params
branch
from
65a6ce6 to
c87a784
Compare
- Contract event ``get_logs()`` has support for ``argument_filters`` but it only works on indexed event arguments. This feature works on unindexed args for ``create_filter()`` / ``build_filter()``. It is ideal to achieve some parity in the same argument for ``get_logs()`` by allowing it here as well.
fselmo
force-pushed
the
update-get-logs-params
branch
from
c87a784 to
a7f8b1e
Compare
pacrob
reviewed
Aug 23, 2023
Co-authored-by: Paul Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
get_logs()has support forargument_filtersbut it only works on indexed event arguments. This feature seems to work on non-indexed args forcreate_filter()/build_filter(). It is ideal to achieve some parity in the same argument forget_logs()by allowing it here as well.How was it fixed?
argument_filterskwarg forget_logs()Todo:
Cute Animal Picture