Update async http docs #3070
Merged
Update async http docs #3070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
update-async-http-docs
branch
from
cc1f146 to
1532d84
Compare
fselmo
reviewed
Aug 2, 2023
fselmo
approved these changes
Aug 2, 2023
Collaborator
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
lgtm 👍🏼 I think we can remove the "exceptions" when comparing to sync HTTPProvider but other than that ship it 🚢
kclowes
force-pushed
the
update-async-http-docs
branch
from
1532d84 to
f477237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
datakey from the Eth-tester RPCError response to standardize with other clients.How was it fixed?
Updated docs, and eth-tester error response.
Todo:
Cute Animal Picture