Catch if data is None in revert error #3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
contract-logic-none-data
branch
from
d61679d to
bb53757
Compare
kclowes
force-pushed
the
contract-logic-none-data
branch
4 times, most recently
from
a7a345d to
58f52fc
Compare
pacrob
reviewed
Jul 24, 2023
pacrob
approved these changes
Jul 24, 2023
Contributor
pacrob
left a comment
pacrob
left a comment
There was a problem hiding this comment.
just some unneeded qa comments, otherwise lgtm!
kclowes
force-pushed
the
contract-logic-none-data
branch
from
5138a39 to
a00bc74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Needed to handle the case when the data key in the JSON-RPC error response was
None.Related to Issue #3051
How was it fixed?
Added a check.
Todo:
Cute Animal Picture