Skip to content

Conversation

@pacrob
Copy link
Contributor

@pacrob pacrob commented May 22, 2023

What was wrong?

The eth_signTypedData is not currently supported by any client. It was supported by Parity/Openethereum, which is now defunct.

How was it fixed?

Added a note to the Web3.eth API docs.

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the sign-typed-data-unsupported-note branch from 169b9c7 to a2ea28d Compare May 22, 2023 19:15
@pacrob pacrob requested a review from kclowes May 22, 2023 19:16
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛵

@pacrob pacrob merged commit bd4ea34 into ethereum:main May 22, 2023
@pacrob pacrob deleted the sign-typed-data-unsupported-note branch May 22, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants