Skip to content

Add withdrawal formatters to block result formatters #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Add withdrawal formatters to block result formatters #2868

merged 1 commit into from
Mar 21, 2023

Conversation

@fselmo
Copy link
Collaborator

@fselmo fselmo commented Mar 8, 2023 •
edited
Loading

What was wrong?

  • Shanghai will add withdrawals to blocks and withdrawalsRoot to block headers. We should support human-readable values, via result formatters, for these new fields.

How was it fixed?

  • Add and test result formatters for new fields related to withdrawals
  • Manually tested against Sepolia (using https://rpc.sepolia.org) and Zhejiang

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes mentioned this pull request Mar 9, 2023
Closed
@fselmo fselmo marked this pull request as ready for review March 10, 2023 20:52
@fselmo fselmo force-pushed the withdrawal-formatters branch from b9ec201 to 4b27fce Compare March 10, 2023 20:55
@fselmo fselmo requested a review from kclowes March 16, 2023 21:26
@fselmo fselmo assigned pacrob and unassigned pacrob Mar 16, 2023
@fselmo fselmo requested a review from pacrob March 16, 2023 21:26
pacrob
pacrob approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit f551571 into ethereum:master Mar 21, 2023
@fselmo fselmo deleted the withdrawal-formatters branch April 25, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kclowes kclowes Awaiting requested review from kclowes

1 more reviewer

@pacrob pacrob pacrob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fselmo @pacrob