Mark test_async_eth_sign with asyncio #2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
approved these changes
Mar 6, 2023
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Nice catch, thank you! This looks good to me, but we're on a code freeze before stable goes out. I'll merge this as soon as we unfreeze :)
Contributor
Author
|
Thanks, @kclowes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to PR #2833.
test_async_eth_signis missing@pytest.mark.asyncio.How was it fixed?
Mark
test_async_eth_signwith@pytest.mark.asyncio.Todo:
Cute Animal Picture