Add async eth.replace_transaction #2847
Conversation
e3243eric
force-pushed
the
async-replace_transaction
branch
4 times, most recently
from
3da7bde to
12099fd
Compare
e3243eric
force-pushed
the
async-replace_transaction
branch
from
e75399c to
68cfdca
Compare
e3243eric
force-pushed
the
async-replace_transaction
branch
from
68cfdca to
2425352
Compare
| } | ||
| txn_hash = await async_w3.eth.send_transaction(txn_params) | ||
| try: | ||
| async_w3.geth.miner.start() # type: ignore |
There was a problem hiding this comment.
The AsyncGethMiner is not implemented, so I mark this test as an expected failure.
There was a problem hiding this comment.
The go-ethereum miner namespace is now deprecated, but I can help implement it if needed, just like the other async Geth namespaces.
|
|
||
| def prepare_replacement_transaction( | ||
| w3: "Web3", | ||
| w3: Union["Web3", "AsyncWeb3"], |
There was a problem hiding this comment.
The prepare_replacement_transaction doesn't use any async method, so I just reuse the sync version of prepare_replacement_transaction. I'm unsure if it is better to reuse it this way or copy it to async_transactions.py.
There was a problem hiding this comment.
I think leaving it here is the better option. Thanks!
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks @e3243eric!
|
|
||
| def prepare_replacement_transaction( | ||
| w3: "Web3", | ||
| w3: Union["Web3", "AsyncWeb3"], |
There was a problem hiding this comment.
I think leaving it here is the better option. Thanks!
2 participants
What was wrong?
Related to Issue #2824. The
replace_transactionmethod is unavailable on theAsyncEthclass.How was it fixed?
Add the
replace_transactionmethod to theAsyncEthclass, and add corresponding tests.Todo:
Cute Animal Picture