Remove deprecated request async #2810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
approved these changes
Feb 8, 2023
Collaborator
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
Nice catch 👍🏼... lgtm, just one spelling blip on the newsfragment 👀
newsfragments/2810.breaking.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Removed deprecated ``manager.request_async`` and assocated methods. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| Removed deprecated ``manager.request_async`` and assocated methods. | |
| Removed deprecated ``manager.request_async`` and associated methods. |
kclowes
force-pushed
the
remove-deprecated-request-async
branch
from
e1e99ca to
73ef817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I noticed that there was a deprecated method that wasn't being used anywhere. No time like the present to remove deprecated things.
How was it fixed?
Removed it and associated methods.
Todo:
Cute Animal Picture