Update isort and black #2802
Merged
Update isort and black #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move isort config into a single config file, ``.isort.cfg``, rather than having it spread between ``tox.ini`` and ``pyproject.toml`` - Update ``isort``, add recommended changes for migrating to isort >5
fselmo
force-pushed
the
update-isort-and-black
branch
2 times, most recently
from
4291ea6 to
23f8e97
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Feb 1, 2023
- Exclude py37 since this was causing some issues with mypy and python 3.7 is slated for deprecation in a few months. Since this is just the linting, this should be OK.
fselmo
force-pushed
the
update-isort-and-black
branch
from
b5465ed to
b3b1e80
Compare
fselmo
commented
Feb 1, 2023
kclowes
approved these changes
Feb 2, 2023
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
I had a couple comments for my own education, but LGTM! 🚢 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
isortwas broken for python 3.10 and above.blackversion was released and causing lint errors.How was it fixed?
isort, add migration guide related changes, and run the updated isort to normalize the code base for the new version.blacklinting with new version as a separate commit.mypyand 3.7 is slated for deprecation in a few months. We still test against 3.7 but linting errors should be OK.Todo:
Cute Animal Picture
shaved moog is sad moog 🙁
