Use build for build commands. #2714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
do-not-invoke-setup-py-directly
branch
9 times, most recently
from
d451a63 to
81ad5f5
Compare
fselmo
force-pushed
the
do-not-invoke-setup-py-directly
branch
18 times, most recently
from
c9e24d8 to
0c905e8
Compare
- use ``python -m build`` instead of invoking ``setup.py`` directly as the latter is strongly discouraged. - invoke ``tox`` correctly for windows circleci job. - consolidate commands in ``tox.ini`` - use circleci orb [email protected] which uses python 3.10 + update the python path in config.yml to reflect this
fselmo
force-pushed
the
do-not-invoke-setup-py-directly
branch
from
0c905e8 to
b9ad4f7
Compare
kclowes
approved these changes
Feb 24, 2023
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Hooray! Looks good to me! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Remove direct invocations of
setup.pyHow was it fixed?
setup.pyand replaced withpython -m build[email protected]which usespy310+ change tox path to reflect this new path inconfig.ymltox.initestenvsTodo:
Cute Animal Picture