refactor and add async beacon api #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
async-beacon-api
branch
3 times, most recently
from
f31c2b7 to
6225c95
Compare
fselmo
force-pushed
the
async-beacon-api
branch
5 times, most recently
from
3cb8d2f to
1bd2463
Compare
fselmo
changed the title
fselmo
force-pushed
the
async-beacon-api
branch
from
1bd2463 to
0956704
Compare
fselmo
force-pushed
the
async-beacon-api
branch
2 times, most recently
from
d3b8382 to
271c801
Compare
fselmo
force-pushed
the
async-beacon-api
branch
from
271c801 to
25dde05
Compare
- Refactor beacon API endpoints into a separate file to be shared by sync and async. - Add async support for beacon api. - Add testing for async beacon.
- Refactor the new ``GET`` methods to be more specific to json responses and add tests: ``(async_)json_make_get_request`` - Add test for async ``make_post_request`` since there was none
fselmo
force-pushed
the
async-beacon-api
branch
from
25dde05 to
06dcb72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #2681
How was it fixed?
Todo:
Cute Animal Picture