Better messaging for wrong arguments to tuple types #2556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
better-messaging-for-tuple-types
branch
4 times, most recently
from
4f19e5e to
59edecc
Compare
fselmo
force-pushed
the
better-messaging-for-tuple-types
branch
2 times, most recently
from
4295991 to
1a46200
Compare
fselmo
changed the title
fselmo
force-pushed
the
better-messaging-for-tuple-types
branch
3 times, most recently
from
48c1e62 to
ea50d26
Compare
kclowes
approved these changes
Jul 7, 2022
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
LGTM! Thanks for updating the newsfragment README too 💥
- collapse tuple types into their nested types for the recognized function signature(s) - collapse user argument types to better compare against the recognized function signature(s)
fselmo
force-pushed
the
better-messaging-for-tuple-types
branch
from
ea50d26 to
0df507e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Contract function signatures in our error messages were only ever read as
<class 'tuple'>fortuple/structargument types. This makes it very difficult to compare user-provided arguments to the function signature.How was it fixed?
tupleargument types in the identified function signature(s)Todo:
Cute Animal Picture