Skip to content

Core Test Cleanups #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kclowes opened this issue May 5, 2022 · 0 comments
Open

Core Test Cleanups #2460

kclowes opened this issue May 5, 2022 · 0 comments
Labels
priority: p3 nice to have

Comments

@kclowes
Copy link
Collaborator

kclowes commented May 5, 2022 •
edited
Loading

What was wrong?

There are some test cleanups that we'd like to look into.

How can it be fixed?

Some ideas which should probably be separate PRs if implemented:

  • explore the possibility of sharing contracts between async_w3 and w3.
  • explore skip_if_testrpc. Decide if they add enough documentation to keep around, or if documentation should be moved to the docs.
  • explore which tests (if any) can be removed from the async core tests
  • split async core tests into a separate tox run
  • some of the emitter fixtures (and maybe others?) are duplicated throughout the tests, explore correcting the scope of the fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kclowes