Skip to content

Conversation

@pacrob
Copy link
Contributor

@pacrob pacrob commented Jan 13, 2022

What was wrong?

AsyncHTTPProvider example used components without importing them

How was it fixed?

Added import lines

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@pacrob pacrob force-pushed the fix_async_sample_imports branch from 5217a92 to 34feff5 Compare January 13, 2022 21:44
@pacrob pacrob force-pushed the fix_async_sample_imports branch from 34feff5 to 9481876 Compare January 13, 2022 21:45
@pacrob pacrob requested review from fselmo, kclowes and wolovim January 13, 2022 21:55
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@pacrob pacrob merged commit 0e6b54b into ethereum:master Jan 13, 2022
@pacrob pacrob deleted the fix_async_sample_imports branch January 13, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants