Skip to content

Conversation

@fafrd
Copy link
Contributor

@fafrd fafrd commented Oct 6, 2021

Previous link to websockets library docs was incorrect.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this! I think the corresponding doc section is: https://websockets.readthedocs.io/en/stable/reference/client.html#websockets.client.WebSocketClientProtocol. Let me know if you don't want to/don't have time to update and I can get it in!

@kclowes
Copy link
Collaborator

kclowes commented Oct 6, 2021

Also, those tests are flaky. I just re-ran them so hopefully that will take care of it!

@fafrd
Copy link
Contributor Author

fafrd commented Oct 6, 2021

Fixed!

I did this all via the github web editor btw, didn't have to clone anything locally- this was surprisingly easy.

@kclowes
Copy link
Collaborator

kclowes commented Oct 14, 2021

Awesome, thank you! Glad to hear it!

@kclowes kclowes merged commit fb8a329 into ethereum:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants