Don't apply geth poa field remapping if result is None #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
fix-geth-poa-middleware
branch
from
44e99c0 to
159d7d6
Compare
kclowes
force-pushed
the
fix-geth-poa-middleware
branch
from
159d7d6 to
6757ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Geth POA middleware was erroring out if the response that came back was
None.Fixes #2063
How was it fixed?
Added a test that replicated the issue, and then added a null check to make sure that formatters weren't getting applied unless a dictionary is present.
Todo:
Cute Animal Picture