deprecate signTypedData in favor of sign_typed_data #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmckenzie51
force-pushed
the
tiffany/signTypedData-to-snakecase
branch
from
b36a0a3 to
1122619
Compare
tmckenzie51
changed the title
tmckenzie51
force-pushed
the
tiffany/signTypedData-to-snakecase
branch
from
5c7108f to
1d7fee9
Compare
kclowes
approved these changes
Mar 31, 2021
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Looks good to me! I just left one nitpicky comment :) Feel free to take it or leave it and merge when you're ready!
Co-authored-by: kclowes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
added sign_typed_data, deprecated signTypedData
Related to Issue #1429
Todo:
Cute Animal Picture