deprecate estimateGas in favor of estimate_gas #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmckenzie51
force-pushed
the
tiffany/estimateGas-to-snakecase
branch
from
3ebe347 to
c05297c
Compare
tmckenzie51
changed the title
tmckenzie51
force-pushed
the
tiffany/estimateGas-to-snakecase
branch
from
304835e to
e0d07c6
Compare
tmckenzie51
force-pushed
the
tiffany/estimateGas-to-snakecase
branch
from
fadd5d8 to
c31dbdc
Compare
kclowes
approved these changes
Mar 31, 2021
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
Looks like you missed an estimateGas in web3/contract.py on line 642, and line 1618. Manual testing looks good!
kclowes
reviewed
Apr 2, 2021
kclowes
reviewed
Apr 2, 2021
kclowes
force-pushed
the
tiffany/estimateGas-to-snakecase
branch
from
7056d1b to
750ace4
Compare
kclowes
force-pushed
the
tiffany/estimateGas-to-snakecase
branch
from
750ace4 to
b195cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added estimate_gas, deprecated estimateGas
Related to Issue #1429
Todo:
Cute Animal Picture