deprecate modifyTransaction in favor of snakecased modify_transaction #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolovim
reviewed
Feb 25, 2021
Member
wolovim
left a comment
wolovim
left a comment
There was a problem hiding this comment.
Looking good on a quick scan, but I expected to find a DeprecationWarning thrown by at least one of the tests. (An example for context.)
tmckenzie51
force-pushed
the
tiffany/modifyTrans-to-snakecase
branch
from
0af84d3 to
63ec776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added modify_transaction, deprecated modifyTransaction
Related to Issue #1429
Todo:
Cute Animal Picture