Move eth_getTransactionCount to snake case #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
eth-get-transaction-count-at-snake-case
branch
from
f010bab to
ab5a1ec
Compare
Collaborator
|
I caught this up with master, and removed the fixture you added so your parity integration tests should pass now! I'll do a more thorough review on Monday! Thanks! |
kclowes
force-pushed
the
eth-get-transaction-count-at-snake-case
branch
from
e5e0ee5 to
7dba288
Compare
kclowes
force-pushed
the
eth-get-transaction-count-at-snake-case
branch
from
7dba288 to
298ee94
Compare
kclowes
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
getTransactionCount needed to be moved to snake case.
Related to Issue #1429
How was it fixed?
Fix not complete only initialized pull request to avoid overlapping work
Todo:
Cute Animal Picture