Swap SolidityError for ContractLogicError #1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kclowes
changed the title
wolovim
reviewed
Dec 18, 2020
kclowes
changed the title
kclowes
force-pushed
the
swap-solidity-err-for-tx-err
branch
from
7a9c4a9 to
9acd13c
Compare
fubuloubu
reviewed
Jan 8, 2021
kclowes
changed the title
kclowes
force-pushed
the
swap-solidity-err-for-tx-err
branch
2 times, most recently
from
2b5604f to
9a59f49
Compare
kclowes
changed the title
kclowes
force-pushed
the
swap-solidity-err-for-tx-err
branch
from
9a59f49 to
e370d16
Compare
wolovim
approved these changes
Jan 13, 2021
Member
wolovim
left a comment
wolovim
left a comment
There was a problem hiding this comment.
the sweet satisfaction of a well-named thing 🙏
(hopefully this ages well 😅 )
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is branched off of #1813, so should be merged after.
What was wrong?
The SolidityError introduced in #1585 should be more generic to account for other languages.
Related to Issue #1813, #1585
How was it fixed?
Swapped out
SolidityErrorfor aContractLogicError.ContractLogicErrorinherits from the SolidityError for backwards compatibility, and we'll removeSolidityErrorin v6. Although the history doesn't reflect this any more, I made the change in the code without making any changes to the tests to make sure we had backwards compatibility, then made the change in the tests.Todo:
Cute Animal Picture