Move getBalance to snake_case #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolovim
approved these changes
Dec 16, 2020
|
Why was only one method migrated to snake case? As a newcomer to the library, reading the
|
Collaborator
Author
|
@jarednielsen Because it's a work in progress. I opted for many smaller PRs instead of one big one with all the methods. Sorry for the confusion! |
|
No worries. Thanks a million for your hard work on the library :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The eth module still has methods that haven't been switched to snake_case. This PR moves
get_balance.Related to Issue #1429
How was it fixed?
added a
get_balancemethod and deprecatedgetBalance.Todo:
Cute Animal Picture