Skip to content

Conversation

@wolovim
Copy link
Member

@wolovim wolovim commented Oct 30, 2020

What was wrong?

Fixture generation has seen some churn in recent PRs. Could still be made easier, but at least now there's some documentation.

Preview: https://web3py--1787.org.readthedocs.build/en/1787/contributing.html#generating-new-fixtures

Todo:

Cute Animal Picture

@wolovim wolovim requested a review from kclowes October 30, 2020 22:37
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this up! Just left a few comments 👍 take 'em or leave 'em

@wolovim wolovim merged commit 7947544 into ethereum:master Nov 2, 2020
@wolovim wolovim deleted the docs-fixtures branch November 2, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants