Update eth-tester dependency #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
approved these changes
Oct 27, 2020
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks @njgheorghita! Did you happen to test it locally to make sure it installs? And will you please add a newsfragment before you merge? Thank you!
njgheorghita
force-pushed
the
update-tester-setup
branch
from
bd29064 to
645c49b
Compare
Contributor
Author
|
Thanks! Everything's working smoothly for me locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
It seems to me that using
web3[tester]was broken recently - due to the recent version bump in pyrlp.Whenever installing a
web3[tester]environment - I'd get ...How was it fixed?
A new version of
eth-testerwas just released that has the updated version ofpy-evm->pyrlp.Todo:
Cute Animal Picture