Allow for ENS name resolution #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
accept-ens-names
branch
4 times, most recently
from
3837e56 to
672f6d9
Compare
| @@ -1,6 +1,10 @@ | |||
| import pytest | |||
|
|
|||
| from web3._utils.ens import ( | |||
Member
There was a problem hiding this comment.
Random plumbing work that should be done at some point. Anything under the web3 namespace like this that is purely a testing tool should get moved to live under web3.tools
kclowes
force-pushed
the
accept-ens-names
branch
2 times, most recently
from
3432aac to
4319ae9
Compare
kclowes
force-pushed
the
accept-ens-names
branch
from
4319ae9 to
b641537
Compare
kclowes
changed the title
wolovim
approved these changes
Sep 24, 2020
Member
wolovim
left a comment
wolovim
left a comment
There was a problem hiding this comment.
Looks good via manual testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ENS names were throwing an
InvalidAddressin methods that were usingMethod.Related to Issue #1585
How was it fixed?
Added a new method that does a high-level validation of an ENS address, before it gets resolved in the middleware.
Todo:
Cute Animal Picture