Skip to content

docs: getBalance example and denomination context #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2020
Merged

docs: getBalance example and denomination context #1676

merged 2 commits into from
Jun 29, 2020

Conversation

@wolovim
Copy link
Member

@wolovim wolovim commented Jun 22, 2020 •
edited
Loading

What was wrong?

While thinking more about new user onboarding, I often circle back to a tutorial. The examples page is roughly that already, so what I have in mind is just to connect more dots between each example. Will tackle that in small chunks for ease of review.

How was it fixed?

  • Introduced getBalance example
  • Added more context to fromWei and toWei examples

Todo:

Cute Animal Picture

@wolovim wolovim requested a review from cburgdorf June 29, 2020 15:13
cburgdorf
cburgdorf approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolovim wolovim merged commit 9d2374b into ethereum:master Jun 29, 2020
@wolovim wolovim deleted the onboarding-docs-pt3 branch June 29, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cburgdorf cburgdorf cburgdorf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wolovim @cburgdorf