add ExtraDataLengthError #1666
Merged
add ExtraDataLengthError #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
approved these changes
Jun 3, 2020
Contributor
cburgdorf
left a comment
cburgdorf
left a comment
There was a problem hiding this comment.
This looks good (I also read the gitter convo) 👍
Member
|
Thanks for the PR @iamdefinitelyahuman. Just needs a newsfragment, which I'll add then merge in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When a POA network returns >32 bytes of
extraDataaValidationErroris raised. Because this exception is also used for other errors, it is difficult to specifically target and handle the issue.Originally discussed on Gitter.
How was it fixed?
To more effectively handle this specific situation, I had added a new exception
ExtraDataLengthErrorwhich is only raised in this case. The new exception is a subclass ofValidationErrorso this shouldn't break any existing code.Cute Animal Picture