Increase replacement transaction minimum gas price bump to 12.5% #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parity requires a gas price 12.5% higher than the previous one to accept a replacement transaction in its transaction queue.
kclowes
approved these changes
Feb 20, 2020
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
LGTM! Will you add a newsfragment before merging please @marcgarreau?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity requires a gas price 12.5% higher than the previous one to accept
a replacement transaction in its transaction queue.
The previous value of 10% only worked for Geth.
See https://wiki.parity.io/Transactions-Queue and
https://github.com/paritytech/parity-ethereum/blob/e69539357f50d20bff51df28c556af8663552eec/miner/src/pool/scoring.rs#L38
How was it fixed?
Increase to 12.5%.
Cute Animal Picture